Skip to content

feat: Add local tests for s3 registry using minio #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 5 commits into from
Mar 30, 2024
+58 −4
Merged

feat: Add local tests for s3 registry using minio #4029

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b846a1
add minio tests for registry
tokoko Mar 21, 2024
90f5d19
clear out session token in for minio tests
tokoko Mar 22, 2024
07ba6d6
log environ keys to stdout
tokoko Mar 22, 2024
fc3576d
skip minio registry from cloud integration tests
tokoko Mar 22, 2024
6502304
Merge branch 'master' into minio-registry-test
tokoko Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clear out session token in for minio tests 
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
  • Loading branch information
@tokoko
tokoko committed Mar 22, 2024
commit 90f5d198cd9307978ffdbd1df2a04e5259721f59
1 change: 1 addition & 0 deletions sdk/python/tests/integration/registration/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def minio_registry() -> Registry:
"FEAST_S3_ENDPOINT_URL": f"http://{container_host}:{exposed_port}",
"AWS_ACCESS_KEY_ID": minio_user,
"AWS_SECRET_ACCESS_KEY": minio_password,
"AWS_SESSION_TOKEN": ""
}

with mock.patch.dict(os.environ, mock_environ):
Expand Down