Skip to content

feat: Updating protos to separate transformation #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 18 commits into from
Mar 24, 2024
Merged

feat: Updating protos to separate transformation #4018

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8f97cf1
feat: updating protos to separate transformation
franciscojavierarceo Mar 17, 2024
bc981c7
fixed stuff...i think
franciscojavierarceo Mar 17, 2024
326ca4a
updated tests and registry diff function
franciscojavierarceo Mar 18, 2024
0ea16a3
updated base registry
franciscojavierarceo Mar 18, 2024
5121d8d
updated react component
franciscojavierarceo Mar 18, 2024
cbbfcf8
formatted
franciscojavierarceo Mar 18, 2024
01b82c8
updated stream feature view proto
franciscojavierarceo Mar 18, 2024
8712b2e
making the proto changes backwards compatable
franciscojavierarceo Mar 18, 2024
f1e3764
trying to make this backwards compatible
franciscojavierarceo Mar 20, 2024
21c1c35
caught a bug and fixed the linter
franciscojavierarceo Mar 20, 2024
ff57b45
actually linted
franciscojavierarceo Mar 20, 2024
6de6fcc
updated ui component
franciscojavierarceo Mar 20, 2024
1212c12
accidentally commented out fixtures
franciscojavierarceo Mar 20, 2024
2883d1b
Updated
franciscojavierarceo Mar 22, 2024
ea5e559
incrementing protos
franciscojavierarceo Mar 22, 2024
ef0795b
updated tests
franciscojavierarceo Mar 22, 2024
529acac
fixed linting issue and made backwards compatible
franciscojavierarceo Mar 22, 2024
6748fe7
added more tests
franciscojavierarceo Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated tests and registry diff function 
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Mar 18, 2024
commit 326ca4a27832ddd0beb60b224da12b9ccb50f130
2 changes: 1 addition & 1 deletion sdk/python/feast/diff/registry_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def diff_registry_objects(
if _field.name in FIELDS_TO_IGNORE:
continue
elif getattr(current_spec, _field.name) != getattr(new_spec, _field.name):
if _field.name == "user_defined_function":
if _field.name == "transformation":
current_spec = cast(OnDemandFeatureViewSpec, current_spec)
new_spec = cast(OnDemandFeatureViewSpec, new_spec)
current_udf = current_spec.transformation.user_defined_function
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,14 @@ def from_proto(cls, on_demand_feature_view_proto: OnDemandFeatureViewProto):
)

if (
on_demand_feature_view_proto.spec.WhichOneof("transformation")
on_demand_feature_view_proto.spec.transformation.WhichOneof("transformation")
== "user_defined_function"
):
transformation = OnDemandPandasTransformation.from_proto(
on_demand_feature_view_proto.spec.transformation.user_defined_function
)
elif (
on_demand_feature_view_proto.spec.WhichOneof("transformation")
on_demand_feature_view_proto.spec.transformation.WhichOneof("transformation")
== "on_demand_substrait_transformation"
):
transformation = OnDemandSubstraitTransformation.from_proto(
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/tests/unit/diff/test_registry_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,11 @@ def post_changed(inputs: pd.DataFrame) -> pd.DataFrame:
assert feast_object_diffs.feast_object_property_diffs[0].property_name == "name"
assert (
feast_object_diffs.feast_object_property_diffs[1].property_name
== "user_defined_function.name"
== "transformation.name"
)
assert (
feast_object_diffs.feast_object_property_diffs[2].property_name
== "user_defined_function.body_text"
== "transformation.body_text"
)


Expand Down