Skip to content

fix: Raise error when not able read of file source spark source #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 1 commit into from
Mar 12, 2024
Merged

fix: Raise error when not able read of file source spark source #4005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: raise error when not able to read path sparksource 
Signed-off-by: tanlocnguyen <tanlocnguyen296@gmail.com>
  • Loading branch information
@ElliotNguyen68
ElliotNguyen68 committed Mar 12, 2024
commit 126f350b5ab10dc28d09f9a3e5912c4f7a376345
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from feast import flags_helper
from feast.data_source import DataSource
from feast.errors import DataSourceNoNameException
from feast.errors import DataSourceNoNameException, DataSourceNotFoundException
from feast.infra.offline_stores.offline_utils import get_temp_entity_table_name
from feast.protos.feast.core.DataSource_pb2 import DataSource as DataSourceProto
from feast.protos.feast.core.SavedDataset_pb2 import (
Expand Down Expand Up @@ -179,6 +179,7 @@ def get_table_query_string(self) -> str:
logger.exception(
"Spark read of file source failed.\n" + traceback.format_exc()
)
raise DataSourceNotFoundException(self.path)
tmp_table_name = get_temp_entity_table_name()
df.createOrReplaceTempView(tmp_table_name)

Expand Down