Skip to content

feat: Dropping Python 3.8 from local integration tests and integration tests #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 2 commits into from
Mar 7, 2024
Merged

feat: Dropping Python 3.8 from local integration tests and integration tests #3994

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106656f
feat: Dropping Python 3.8 integration tests
franciscojavierarceo Mar 7, 2024
43e0c3f
updated integration tests
franciscojavierarceo Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
updated integration tests 
Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Mar 7, 2024
commit 43e0c3f5a7c44fa1a81f795ee97f017766f9f2f3
4 changes: 2 additions & 2 deletions .github/workflows/pr_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ "3.8", "3.10" ]
python-version: [ "3.10" ]
os: [ ubuntu-latest ]
env:
OS: ${{ matrix.os }}
Expand Down Expand Up @@ -167,4 +167,4 @@ jobs:
SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
run: pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread
run: pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread
Copy link
Copy Markdown
Member Author

@franciscojavierarceo franciscojavierarceo Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this detected change is strange.

Copy link
Copy Markdown
Collaborator

@jeremyary jeremyary Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is strange, must've picked up a newline somehow/somewhere before we got to it