Skip to content

feat: Pandas v2 compatibility #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 9 commits into from
Mar 4, 2024
Merged

feat: Pandas v2 compatibility #3957

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bd2d690
feat: Support pandas v2
sudohainguyen Feb 18, 2024
9ec43d8
fix: Prune dependencies
sudohainguyen Feb 18, 2024
d8978f4
chore: Re-compile reqs py310
sudohainguyen Feb 18, 2024
ba7d048
fix: Mark test skip with conditions
sudohainguyen Feb 18, 2024
30a535a
chore: Re-compile reqs py39
sudohainguyen Feb 18, 2024
f291b90
chore: Update skip reason
sudohainguyen Feb 18, 2024
8cbbc6f
chore: Re-compile reqs py38
sudohainguyen Feb 19, 2024
3324f39
chore: Bump snowflake connector
sudohainguyen Feb 23, 2024
a0e966b
chore: Remove test skip
sudohainguyen Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Mark test skip with conditions 
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
  • Loading branch information
@sudohainguyen
sudohainguyen committed Mar 2, 2024
commit ba7d048c0d076ffb18788c90c699335d018fcd96
5 changes: 5 additions & 0 deletions sdk/python/tests/integration/offline_store/test_feature_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
@pytest.mark.integration
@pytest.mark.universal_offline_stores
@pytest.mark.parametrize("pass_as_path", [True, False], ids=lambda v: str(v))
@pytest.mark.skipif(
Copy link
Copy Markdown
Collaborator

@tokoko tokoko Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 2.0.3 also contain this bug? If so, even after snowflake is released, 3.8 tests will still fail once we remove skipifs as the latest pandas release in 3.8 is 2.0.3. Will we need to pin pandas version below 2.0.0 only for python 3.8 using environment markers?

Copy link
Copy Markdown
Collaborator Author

@sudohainguyen sudohainguyen Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well actually the bug appears running pandas testing only,
it does not affect to features though

Copy link
Copy Markdown
Collaborator

@tokoko tokoko Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still, wdyt about adding something like this in our ci extras: pandas < 2.0.0 : python_version == '3.8'. Would be better than skipping the tests entirely.

pd.__version__ < "2.2.0" and pd.__version__ >= "2.0.0",
reason="Requires pandas version 2.2.0 or higher",
# https://github.com/pandas-dev/pandas/issues/55730
)
def test_feature_service_logging(environment, universal_data_sources, pass_as_path):
store = environment.feature_store

Expand Down
5 changes: 5 additions & 0 deletions sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,11 @@ def test_historical_features_with_no_ttl(

@pytest.mark.integration
@pytest.mark.universal_offline_stores
@pytest.mark.skipif(
pd.__version__ < "2.2.0" and pd.__version__ >= "2.0.0",
reason="Requires pandas version 2.2.0 or higher",
# https://github.com/pandas-dev/pandas/issues/55730
)
def test_historical_features_from_bigquery_sources_containing_backfills(environment):
store = environment.feature_store

Expand Down