Skip to content

fix: Revert mypy config #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuchu merged 5 commits into from
Feb 20, 2024
Merged

fix: Revert mypy config #3952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e05cf2
fetch_arrow_all returns empty table
bushwhackr Feb 16, 2024
04de64c
fix spark_kafka_processor typing errors
bushwhackr Feb 16, 2024
696d5d6
fix correct return type
bushwhackr Feb 16, 2024
bbcce21
revert _to_arrow_internal
bushwhackr Feb 16, 2024
1aac1e9
revert kafkaStreamProcessor changes, change base type instead
bushwhackr Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fetch_arrow_all returns empty table 
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
  • Loading branch information
@bushwhackr
bushwhackr committed Feb 16, 2024
commit 6e05cf2e4a81e087f732bd88e6cc36313c933e8c
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ format-python:
cd ${ROOT_DIR}/sdk/python; python -m black --target-version py38 feast tests

lint-python:
cd ${ROOT_DIR}/sdk/python; python -m mypy --exclude=/tests/ --follow-imports=skip feast
cd ${ROOT_DIR}/sdk/python; python -m mypy --exclude=/tests/ feast
cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/ --check-only
cd ${ROOT_DIR}/sdk/python; python -m flake8 feast/ tests/
cd ${ROOT_DIR}/sdk/python; python -m black --check feast tests
Expand Down
13 changes: 2 additions & 11 deletions sdk/python/feast/infra/offline_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,18 +470,9 @@ def _to_df_internal(self, timeout: Optional[int] = None) -> pd.DataFrame:
def _to_arrow_internal(self, timeout: Optional[int] = None) -> pyarrow.Table:
pa_table = execute_snowflake_statement(
self.snowflake_conn, self.to_sql()
).fetch_arrow_all()
).fetch_arrow_all(force_return_table=True)

if pa_table:
return pa_table
else:
empty_result = execute_snowflake_statement(
self.snowflake_conn, self.to_sql()
)

return pyarrow.Table.from_pandas(
pd.DataFrame(columns=[md.name for md in empty_result.description])
)
return pa_table
Comment thread
bushwhackr marked this conversation as resolved.
Outdated

def to_sql(self) -> str:
"""
Expand Down