Skip to content

feat: Add gRPC Registry Server #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 3 commits into from
Feb 6, 2024
Merged

feat: Add gRPC Registry Server #3924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9841637
feat: Add grpc registry server
tokoko Feb 1, 2024
cf0c441
fix: Add allow_cache to base registry get_request_feature_view
tokoko Feb 1, 2024
cfe1585
fix: registry server linter issues
tokoko Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Add allow_cache to base registry get_request_feature_view 
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
  • Loading branch information
@tokoko
tokoko committed Feb 1, 2024
commit cf0c4415e35cf4c2de40ed4c3eec2bcc23b7cb70
4 changes: 3 additions & 1 deletion sdk/python/feast/infra/registry/base_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,9 @@ def list_feature_views(

# request feature view operations
@abstractmethod
def get_request_feature_view(self, name: str, project: str) -> RequestFeatureView:
def get_request_feature_view(
self, name: str, project: str, allow_cache: bool = False
) -> RequestFeatureView:
"""
Retrieves a request feature view.

Expand Down
8 changes: 6 additions & 2 deletions sdk/python/feast/infra/registry/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,12 @@ def list_feature_views(
)
return proto_registry_utils.list_feature_views(registry_proto, project)

def get_request_feature_view(self, name: str, project: str):
registry_proto = self._get_registry_proto(project=project, allow_cache=False)
def get_request_feature_view(
self, name: str, project: str, allow_cache: bool = False
):
registry_proto = self._get_registry_proto(
project=project, allow_cache=allow_cache
)
return proto_registry_utils.get_request_feature_view(
registry_proto, name, project
)
Expand Down