Skip to content

fix: Add conn.commit() to Postgresonline_write_batch.online_write_batch #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 1 commit into from
Feb 9, 2024
Merged

fix: Add conn.commit() to Postgresonline_write_batch.online_write_batch #3904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add conn.commit() to Postgresonline_write_batch.online_write_batch 
Signed-off-by: Job Almekinders <55230856+job-almekinders@users.noreply.github.com>
  • Loading branch information
@job-almekinders
job-almekinders committed Feb 5, 2024
commit bb42cc2f52846b56cd862eb0af2d1faad0abd298
1 change: 1 addition & 0 deletions sdk/python/feast/infra/online_stores/contrib/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def online_write_batch(
cur_batch,
page_size=batch_size,
)
conn.commit()
if progress:
progress(len(cur_batch))

Expand Down