Skip to content

feat: Support s3gov schema by snowflake offline store during materialization #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 3 commits into from
Jan 27, 2024
Merged

feat: Support s3gov schema by snowflake offline store during materialization #3891

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c98a5b
SAASMLOPS-1058-2 Support s3gov schema by snowflake offline store duri…
alex-vinnik-sp Jan 17, 2024
4fb6a79
SAASMLOPS-1058-2 Add unit test for to_remote_storage
alex-vinnik-sp Jan 20, 2024
00be0e4
SAASMLOPS-1058-2 Reformat code
alex-vinnik-sp Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
SAASMLOPS-1058-2 Support s3gov schema by snowflake offline store duri… 
…ng materialization

Signed-off-by: Alex Vinnik <alex.vinnik@sailpoint.com>
  • Loading branch information
@alex-vinnik-sp
alex-vinnik-sp committed Jan 22, 2024
commit 0c98a5b2c65fa3b528f230687776cb57dedd456a
4 changes: 3 additions & 1 deletion sdk/python/feast/infra/offline_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,10 @@ def to_remote_storage(self) -> List[str]:
file_name_column_index = [
idx for idx, rm in enumerate(cursor.description) if rm.name == "FILE_NAME"
][0]
# s3gov schema is used by Snowflake in AWS govcloud regions
native_export_path = self.export_path.replace("s3gov://", "s3://")
return [
f"{self.export_path}/{row[file_name_column_index]}"
f"{native_export_path}/{row[file_name_column_index]}"
for row in cursor.fetchall()
]

Expand Down