Skip to content

fix: Handle ComplexFeastType to None comparison #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoxu0 merged 1 commit into from
Mar 7, 2024
Merged

fix: Handle ComplexFeastType to None comparison #3876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Handle ComplexFeastType to None comparison 
Signed-off-by: Aliaksandr Sasnouskikh <jahstreetlove@gmail.com>
  • Loading branch information
@jahstreet
jahstreet committed Jan 5, 2024
commit 70bf1fde8f4cf368fcb91a94e9887ae3f574b6ed
5 changes: 4 additions & 1 deletion sdk/python/feast/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ def __hash__(self):
return hash(self.to_value_type().value)

def __eq__(self, other):
return self.to_value_type() == other.to_value_type()
if isinstance(other, ComplexFeastType):
return self.to_value_type() == other.to_value_type()
else:
return False


class PrimitiveFeastType(Enum):
Expand Down