Skip to content

feat: Added delete_table to redis online store #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 2 commits into from
Mar 4, 2024
Merged

feat: Added delete_table to redis online store #3857

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad685e
feat: Added delete_table to redis online store
j1wonpark Dec 11, 2023
4732440
fix: Fix hdel params to *args
j1wonpark Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Fix hdel params to *args 
Signed-off-by: Jiwon Park <phil.park@sktelecom.com>
  • Loading branch information
@j1wonpark
j1wonpark committed Feb 11, 2024
commit 4732440da069687b53bafe29e4d05e1f3caee442
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/online_stores/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def delete_table(self, config: RepoConfig, table: FeatureView):
if len(_tables) == 1:
pipe.delete(_k)
else:
pipe.hdel(_k, redis_hash_keys)
pipe.hdel(_k, *redis_hash_keys)
deleted_count += 1
pipe.execute()

Expand Down