Skip to content

fix: Adopt connection pooling for HBase #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achals merged 4 commits into from
Oct 21, 2023
Merged

fix: Adopt connection pooling for HBase #3793

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb9cd96
fix: Adopt connection pooling for HBase
sudohainguyen Oct 21, 2023
9a1c5a2
chore: Rename hbaseutils to HBaseConnector
sudohainguyen Oct 21, 2023
d272e75
feat: Expose thrift connection configuration to hbase online store co…
sudohainguyen Oct 21, 2023
744df52
fix: check fv entities emptiness before if the first one is dummy
sudohainguyen Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: check fv entities emptiness before if the first one is dummy 
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
  • Loading branch information
@sudohainguyen
sudohainguyen committed Oct 21, 2023
commit 744df526cae2e266e1b6bc3e3749dd9f339f2575
6 changes: 5 additions & 1 deletion sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,11 @@ def _list_feature_views(
for fv in self._registry.list_feature_views(
self.project, allow_cache=allow_cache
):
if hide_dummy_entity and fv.entities[0] == DUMMY_ENTITY_NAME:
if (
hide_dummy_entity
and fv.entities
and fv.entities[0] == DUMMY_ENTITY_NAME
):
fv.entities = []
fv.entity_columns = []
feature_views.append(fv)
Expand Down