Skip to content

feat: Add materialize and materialize-incremental rest endpoints #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixwang9817 merged 2 commits into from
Sep 12, 2023
Merged

feat: Add materialize and materialize-incremental rest endpoints #3761

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e93562c
resolve #3760
snowron Sep 12, 2023
0dbf03a
format feature_server.py
snowron Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format feature_server.py 
Signed-off-by: snowron <snowronark@gmail.com>
  • Loading branch information
@snowron
snowron committed Sep 12, 2023
commit 0dbf03a1e4a535def16f201b16e4c81d771ef5c5
21 changes: 13 additions & 8 deletions sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
import json
import traceback
from typing import List, Optional
import warnings
from typing import List, Optional

import gunicorn.app.base
import pandas as pd
from dateutil import parser
from fastapi import FastAPI, HTTPException, Request, Response, status
from fastapi.logger import logger
from fastapi.params import Depends
from google.protobuf.json_format import MessageToDict, Parse
from pydantic import BaseModel

import feast
from feast import proto_json
from feast import proto_json, utils
from feast.data_source import PushMode
from feast.errors import PushSourceNotFoundException
from feast.protos.feast.serving.ServingService_pb2 import GetOnlineFeaturesRequest
from dateutil import parser
from feast import utils


# TODO: deprecate this in favor of push features
class WriteToFeatureStoreRequest(BaseModel):
Expand All @@ -38,6 +38,7 @@ class MaterializeRequest(BaseModel):
end_ts: str
feature_views: Optional[List[str]] = None


class MaterializeIncrementalRequest(BaseModel):
end_ts: str
feature_views: Optional[List[str]] = None
Expand Down Expand Up @@ -150,8 +151,11 @@ def health():
def materialize(body=Depends(get_body)):
try:
request = MaterializeRequest(**json.loads(body))
store.materialize(utils.make_tzaware(parser.parse(request.start_ts)), utils.make_tzaware(
parser.parse(request.end_ts)), request.feature_views)
store.materialize(
utils.make_tzaware(parser.parse(request.start_ts)),
utils.make_tzaware(parser.parse(request.end_ts)),
request.feature_views,
)
except Exception as e:
# Print the original exception on the server side
logger.exception(traceback.format_exc())
Expand All @@ -162,8 +166,9 @@ def materialize(body=Depends(get_body)):
def materialize_incremental(body=Depends(get_body)):
try:
request = MaterializeIncrementalRequest(**json.loads(body))
store.materialize_incremental(utils.make_tzaware(
parser.parse(request.end_ts)), request.feature_views)
store.materialize_incremental(
utils.make_tzaware(parser.parse(request.end_ts)), request.feature_views
)
except Exception as e:
# Print the original exception on the server side
logger.exception(traceback.format_exc())
Expand Down