Skip to content

fix: Fix warnings from deprecated paths and update default log level #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 6 commits into from
Sep 7, 2023
Merged

fix: Fix warnings from deprecated paths and update default log level #3757

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ba48f6
fix: Fix warnings from deprecated paths and update default log level …
adchia Sep 7, 2023
91e6d89
lint
adchia Sep 7, 2023
a42d5a9
fix ci
adchia Sep 7, 2023
8a7d1d6
fix lint
adchia Sep 7, 2023
3a40c07
last pkg_resources
adchia Sep 7, 2023
9af1cad
last pkg_resources
adchia Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
last pkg_resources 
Signed-off-by: Danny C <d.chiao@gmail.com>
  • Loading branch information
@adchia
adchia committed Sep 7, 2023
commit 9af1cadbbfd112815f308907c3792a18adcf8681
4 changes: 2 additions & 2 deletions sdk/python/feast/proto_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def from_json_object_updated(

# https://github.com/feast-dev/feast/issues/2484 Certain feast users need a higher version of protobuf but the
# parameters of `from_json_object` changes in feast 3.20.1. This change gives users flexibility to use earlier versions.
current_version = importlib.resources.get_distribution("protobuf").version
current_version = importlib_version("protobuf")
if version.parse(current_version) < version.parse("3.20"):
_patch_proto_json_encoding(Value, to_json_object, from_json_object)
else:
Expand Down Expand Up @@ -221,7 +221,7 @@ def from_json_object_updated(

# https://github.com/feast-dev/feast/issues/2484 Certain feast users need a higher version of protobuf but the
# parameters of `from_json_object` changes in feast 3.20.1. This change gives users flexibility to use earlier versions.
current_version = pkg_resources.get_distribution("protobuf").version
current_version = importlib_version("protobuf")
if version.parse(current_version) < version.parse("3.20"):
_patch_proto_json_encoding(FeatureList, to_json_object, from_json_object)
else:
Expand Down