Skip to content

feat: Add support for in_cluster config and additional labels for bytewax materialization #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 2 commits into from
Sep 21, 2023
Merged

feat: Add support for in_cluster config and additional labels for bytewax materialization #3754

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20d6c7f
SAASMLOPS-734 bytewax in-cluster config, custom labels, fix worker im…
james-crabtree-sp Aug 28, 2023
2a275d3
SAASMLOPS-769 make max parallelism configurable
james-crabtree-sp Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
SAASMLOPS-769 make max parallelism configurable 
Signed-off-by: James Crabtree <james.crabtree@sailpoint.com>
  • Loading branch information
@james-crabtree-sp
james-crabtree-sp committed Sep 14, 2023
commit 2a275d36907d883abb7b994bd306ffd54ba21f13
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ class BytewaxMaterializationEngineConfig(FeastConfigBaseModel):
labels: dict = {}
""" (optional) additional labels to append to kubernetes objects """

max_parallelism: int = 10
""" (optional) Maximum number of pods (default 10) allowed to run in parallel per job"""


class BytewaxMaterializationEngine(BatchMaterializationEngine):
def __init__(
Expand Down Expand Up @@ -275,7 +278,7 @@ def _create_job_definition(self, job_id, namespace, pods, env):
"spec": {
"ttlSecondsAfterFinished": 3600,
"completions": pods,
"parallelism": pods,
"parallelism": min(pods, self.batch_engine_config.max_parallelism),
"completionMode": "Indexed",
"template": {
"metadata": {
Expand Down