Skip to content

fix: Saved datasets no longer break CLI registry-dump command #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 1 commit into from
Sep 7, 2023
Merged

fix: Saved datasets no longer break CLI registry-dump command #3717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Access saved dataset proto correctly in list_saved_datasets 
Signed-off-by: Malcolm Keyes <malcolm.a.keyes@gmail.com>
  • Loading branch information
@malcolmk181 @adchia
malcolmk181 authored and adchia committed Sep 7, 2023
commit 46b06b13e7f92a05ffcfc64a87a3361467ae7cc6
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/proto_registry_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def list_saved_datasets(
) -> List[SavedDataset]:
saved_datasets = []
for saved_dataset in registry_proto.saved_datasets:
if saved_dataset.project == project:
if saved_dataset.spec.project == project:
saved_datasets.append(SavedDataset.from_proto(saved_dataset))
return saved_datasets

Expand Down