Skip to content

Fix installation link in README.md - #368

Merged
woop merged 1 commit into
feast-dev:masterfrom
Jeffwan:fix-doc-link
Dec 17, 2019
Merged

Fix installation link in README.md#368
woop merged 1 commit into
feast-dev:masterfrom
Jeffwan:fix-doc-link

Conversation

@Jeffwan

@Jeffwan Jeffwan commented Dec 15, 2019

Copy link
Copy Markdown
Contributor

README.md Link is broken. Should be installing-feast.md

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeffwan
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop

woop commented Dec 16, 2019

Copy link
Copy Markdown
Member

Thanks @Jeffwan!

Would you mind signing the CLA?

As soon as you do I will merge it in.

@Jeffwan

Jeffwan commented Dec 16, 2019

Copy link
Copy Markdown
Contributor Author

@woop Hi, I already signed CLA. It's the similar one in Kubernetes community, right?
https://cla.developers.google.com/about/google-individual This one?

@woop

woop commented Dec 17, 2019

Copy link
Copy Markdown
Member

@woop Hi, I already signed CLA. It's the similar one in Kubernetes community, right?
https://cla.developers.google.com/about/google-individual This one?

Yes, thank you!

@woop

woop commented Dec 17, 2019

Copy link
Copy Markdown
Member

/lgtm

@woop

woop commented Dec 17, 2019

Copy link
Copy Markdown
Member

/approved

@woop
woop merged commit bc4b974 into feast-dev:master Dec 17, 2019
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@Jeffwan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-core-and-ingestion 4f01d11 link /test test-core-and-ingestion
test-end-to-end-batch 4f01d11 link /test test-end-to-end-batch

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jeffwan
Jeffwan deleted the fix-doc-link branch December 26, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants