Skip to content

chore: Adding logging to the feature server when the registry is refreshed #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 1 commit into from
May 16, 2023
Merged

chore: Adding logging to the feature server when the registry is refreshed #3623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/python/feast/infra/registry/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@ def _get_registry_proto(
assert isinstance(self.cached_registry_proto, RegistryProto)
return self.cached_registry_proto

logger.info("Registry cache expired, so refreshing")
registry_proto = self._registry_store.get_registry_proto()
self.cached_registry_proto = registry_proto
self.cached_registry_proto_created = datetime.utcnow()
Expand Down
4 changes: 4 additions & 0 deletions sdk/python/feast/infra/registry/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logging
import os
import uuid
from binascii import hexlify
Expand Down Expand Up @@ -59,6 +60,8 @@
from feast.saved_dataset import SavedDataset, ValidationReference
from feast.stream_feature_view import StreamFeatureView

logger = logging.getLogger(__name__)


class FeastMetadataKeys(Enum):
LAST_UPDATED_TIMESTAMP = "last_updated_timestamp"
Expand Down Expand Up @@ -174,6 +177,7 @@ def _refresh_cached_registry_if_necessary(self):
)

if expired:
logger.info("Registry cache expired, so refreshing")
self.refresh()

def teardown(self):
Expand Down
4 changes: 4 additions & 0 deletions sdk/python/feast/infra/registry/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logging
import uuid
from datetime import datetime, timedelta
from enum import Enum
Expand Down Expand Up @@ -178,6 +179,8 @@ class FeastMetadataKeys(Enum):
Column("last_updated_timestamp", BigInteger, nullable=False),
)

logger = logging.getLogger(__name__)


class SqlRegistryConfig(RegistryConfig):
registry_type: StrictStr = "sql"
Expand Down Expand Up @@ -256,6 +259,7 @@ def _refresh_cached_registry_if_necessary(self):
)

if expired:
logger.info("Registry cache expired, so refreshing")
self.refresh()

def get_stream_feature_view(
Expand Down