Skip to content

chore: Make publishing the UI to NPM optional - #3559

Merged
achals merged 1 commit into
feast-dev:masterfrom
achals:achal/make-ui-publish-optional
Mar 24, 2023
Merged

chore: Make publishing the UI to NPM optional#3559
achals merged 1 commit into
feast-dev:masterfrom
achals:achal/make-ui-publish-optional

Conversation

@achals

@achals achals commented Mar 24, 2023

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kevjumba kevjumba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
achals merged commit 7e99ccc into feast-dev:master Mar 24, 2023
@achals
achals deleted the achal/make-ui-publish-optional branch March 24, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants