docs: Fix the documentation to run the tutorial Validating historical features with Great Expectations - #3540
Conversation
|
/ok-to-test |
|
@diefergil thanks for the PR! you'll have to sign your commit in order for the DCO check to pass |
Done! |
|
@diefergil actually I don't think the commit was actually signed off? can you try again? |
|
@diefergil are you sure you're following the instructions correctly? I'm still not seeing the signature on your commit |
|
Hello again @felixwang9817 . You were right, I thought the github verified was enough. I have now configured gpg and I think it should be enough. If not, send me a guide on how to configure it properly. Thanks! |
|
@diefergil it's still not working. you can find the instructions here. you'll know that it's working when the DCO check is passing. |
Signed-off-by: Diego <33923877+diefergil@users.noreply.github.com>
|
Now is working! Thanks for your help @felixwang9817! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: diefergil, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… features with Great Expectations (feast-dev#3540) Fix the documentation to run the tutorial Signed-off-by: Diego <33923877+diefergil@users.noreply.github.com> Signed-off-by: zerafachris PERSONAL <zerafachris@gmail.com>
What this PR does / why we need it:
The great expectactions tutorial is not working properly, I managed to run it with some small changes in the code and I thought it would be good to update it.
Which issue(s) this PR fixes:
The complete great expectations tutorial can now be run by copying and pasting the code from the documentation.
Fixes #