Update buildFeatureSets method in Golang SDK to ensure order of FeatureSet in the request follows that from the argument - #351
Merged
feast-ci-bot merged 2 commits intoDec 10, 2019
Conversation
To ensure that the feature set name order in the request follows that from the method argument
davidheryanto
requested review from
pradithya,
thirteen37,
tims,
woop and
zhilingc
as code owners
December 5, 2019 03:25
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of buildFeatureSets method do not ensure such order. However, the unit test expects the order to be respected. This results in failed Golang unit test occasionally.
This pull request update the implementation by not depending on order of iteration of a map object when creating the FeatureSetRequest slice. Map iteration in Golang has random order and therefore cannot be used to ensure ordered output.
Related to #330