Skip to content

fix: Add description attribute to the Field.from_proto method #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 2 commits into from
Feb 3, 2023
Merged

fix: Add description attribute to the Field.from_proto method #3469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cbfad0
fix: Add description attribute to the from_proto method
gbmarc1 Jan 29, 2023
fbe907d
lint
adchia Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Add description attribute to the from_proto method 
Signed-off-by: gbmarc1 <marcantoine.belanger@shopify.com>
  • Loading branch information
@gbmarc1 @adchia
gbmarc1 authored and adchia committed Jan 30, 2023
commit 5cbfad05a286aeb9c185c8b0273c619aedbc4086
1 change: 1 addition & 0 deletions sdk/python/feast/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto):
name=field_proto.name,
dtype=from_value_type(value_type=value_type),
tags=dict(field_proto.tags),
description=field_proto.description,
)

@classmethod
Expand Down
3 changes: 3 additions & 0 deletions sdk/python/tests/unit/test_feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ def test_field_serialization_with_description():

assert serialized_field.description == expected_description
assert field_from_feature.description == expected_description

field = Field.from_proto(serialized_field)
assert field.description == expected_description