Skip to content

Exports GRPC call metrics and Feast resource metrics in Core - #345

Merged
feast-ci-bot merged 6 commits into
feast-dev:masterfrom
davidheryanto:feast-core-metrics
Dec 4, 2019
Merged

Exports GRPC call metrics and Feast resource metrics in Core#345
feast-ci-bot merged 6 commits into
feast-dev:masterfrom
davidheryanto:feast-core-metrics

Conversation

@davidheryanto

@davidheryanto davidheryanto commented Dec 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This pull request adds the following Prometheus metrics to Feast Core:

These metrics can be used to monitor:

  • stability and performance of Feast Core, for example by monitoring the latency, traffic, error and saturation via the histogram values of feast_core_request_latency_seconds.
  • usage of Feast by counting the of Feature Sets and Stores registered in Feast.

Example how Feast Core dashboard can look like:
Screenshot from 2019-12-04 15-36-44

@feast-ci-bot

feast-ci-bot commented Dec 4, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto

davidheryanto commented Dec 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

/hold
I want to export memory (and perhaps CPU) usage of the JVM too.

@davidheryanto

davidheryanto commented Dec 4, 2019

Copy link
Copy Markdown
Collaborator Author

/hold cancel

@zhilingc

zhilingc commented Dec 4, 2019

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit a53e06b into feast-dev:master Dec 4, 2019
@davidheryanto
davidheryanto deleted the feast-core-metrics branch December 4, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradithya pradithya Awaiting requested review from pradithya
@thirteen37 thirteen37 Awaiting requested review from thirteen37
@tims tims Awaiting requested review from tims
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@zhilingc zhilingc

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidheryanto @feast-ci-bot @zhilingc