Skip to content

Add testing folder for deploying test infrastructure and running tests - #34

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
woop:test-infra
Jan 4, 2019
Merged

Add testing folder for deploying test infrastructure and running tests#34
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
woop:test-infra

Conversation

@woop

@woop woop commented Jan 3, 2019

Copy link
Copy Markdown
Member

This PR sets up unit testing using Prow, for issue #2

@woop woop changed the title Test infra Add testing folder deploying test infrastructure and running tests Jan 3, 2019
@woop woop changed the title Add testing folder deploying test infrastructure and running tests Add testing folder for deploying test infrastructure and running tests Jan 3, 2019
@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/test presubmit-unit-tests

1 similar comment
@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/test presubmit-unit-tests

@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/hold

@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/assign tims

@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/assign zhilingc

@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/hold cancel

@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@tims

tims commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

/retest

tims
tims reviewed Jan 3, 2019
View reviewed changes

@tims tims left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tims

tims commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

/approve

@feast-ci-bot feast-ci-bot added approved and removed lgtm labels Jan 3, 2019
@tims

tims commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@woop

woop commented Jan 3, 2019

Copy link
Copy Markdown
Member Author

/lgtm

@feast-ci-bot

feast-ci-bot commented Jan 3, 2019

Copy link
Copy Markdown
Collaborator

@woop: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 4, 2019
@feast-dev feast-dev deleted a comment from feast-ci-bot Jan 4, 2019
@woop

woop commented Jan 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

/retest

@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

/retest

@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

/approve

@zhilingc

zhilingc commented Jan 4, 2019

Copy link
Copy Markdown
Collaborator

/lgtm

@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

/assign zhilingc

@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

/cc zhilingc

@feast-ci-bot
feast-ci-bot requested a review from zhilingc January 4, 2019 02:45
@zhilingc

zhilingc commented Jan 4, 2019

Copy link
Copy Markdown
Collaborator

/accept

zhilingc
zhilingc approved these changes Jan 4, 2019
View reviewed changes

@zhilingc zhilingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual approve

@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

/uncc tims
/cc pradithya

@feast-ci-bot
feast-ci-bot requested a review from pradithya January 4, 2019 02:59
@pradithya

pradithya commented Jan 4, 2019

Copy link
Copy Markdown
Collaborator

/approve

@zhilingc

zhilingc commented Jan 4, 2019

Copy link
Copy Markdown
Collaborator

/approve

@zhilingc

zhilingc commented Jan 4, 2019

Copy link
Copy Markdown
Collaborator

/approve cancel

@feast-ci-bot

feast-ci-bot commented Jan 4, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya, tims, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [pradithya,tims,woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

Do not merge this PR. Our bad bot needs to do his job.

@feast-ci-bot
feast-ci-bot merged commit ccbf615 into feast-dev:master Jan 4, 2019
@woop

woop commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

You did good @feast-ci-bot

dmartinol pushed a commit to dmartinol/feast that referenced this pull request Jul 9, 2024
@redhatHameed
Merge pull request feast-dev#34 from redhatHameed/rbac-doc
13952c7 
added document reference for Permission/RBAC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradithya pradithya pradithya approved these changes
@zhilingc zhilingc zhilingc approved these changes
+1 more reviewer
@tims tims tims left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tims tims

@zhilingc zhilingc

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@woop @tims @feast-ci-bot @zhilingc @pradithya