Skip to content

fix: Specifies timeout in exception polling #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Dec 19, 2022
Merged

fix: Specifies timeout in exception polling #3398

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8edd160
Specifies timeout in exception polling
gbmarc1 Dec 16, 2022
6d46485
Update bigquery.py
gbmarc1 Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Specifies timeout in exception polling 
Signed-off-by: gbmarc1 <marcantoine.belanger@shopify.com>
  • Loading branch information
@gbmarc1
gbmarc1 committed Dec 19, 2022
commit 8edd1606e1b8241fdcb651a91f0cb3ffec5d47e7
7 changes: 5 additions & 2 deletions sdk/python/feast/infra/offline_stores/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,11 @@ def _wait_until_done(bq_job):
client.cancel_job(bq_job.job_id)
raise BigQueryJobCancelled(job_id=bq_job.job_id)

if bq_job.exception():
raise bq_job.exception()
# We explicitly set the timeout to None because `google-api-core` keeps changing default value and
# breaks downstream libraries.
# https://github.com/googleapis/python-api-core/issues/479
if bq_job.exception(timeout=None):
raise bq_job.exception(timeout=None)


def _get_table_reference_for_new_entity(
Expand Down