Skip to content

fix: Update import logic to remove pyspark dependency from Snowflake Offline Store #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 4 commits into from
Dec 18, 2022
Merged

fix: Update import logic to remove pyspark dependency from Snowflake Offline Store #3397

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19d4141
fix: move pyspark import inside relevant method
Dec 15, 2022
14e4bd0
fix: put import inside type checking so that type hints works
Dec 15, 2022
eae29ad
fix: import future annotations
Dec 15, 2022
c04e38c
fix: annotate only the method signature
Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: annotate only the method signature 
Signed-off-by: Ryan Beauchamp <ryan.beauchamp@ezcater.com>
  • Loading branch information
Ryan Beauchamp committed Dec 16, 2022
commit c04e38c8e2ca7e4aafcaf015af77952aed4b68a4
4 changes: 1 addition & 3 deletions sdk/python/feast/infra/offline_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
from __future__ import annotations

import contextlib
import os
import uuid
Expand Down Expand Up @@ -461,7 +459,7 @@ def to_sql(self) -> str:
with self._query_generator() as query:
return query

def to_spark_df(self, spark_session: SparkSession) -> DataFrame:
def to_spark_df(self, spark_session: "SparkSession") -> "DataFrame":
"""
Method to convert snowflake query results to pyspark data frame.

Expand Down