Skip to content

docs: Fix broken links in roadmap page - #3299

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/bad-links
Oct 18, 2022
Merged

docs: Fix broken links in roadmap page#3299
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/bad-links

Conversation

@achals

@achals achals commented Oct 18, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals
docs: Fix broken links in roadmap page
b5c3fbb 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter

codecov-commenter commented Oct 18, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 67.67% // Head: 76.77% // Increases project coverage by +9.09% 🎉

Coverage data is based on head (b5c3fbb) compared to base (104a918).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
+ Coverage   67.67%   76.77%   +9.09%     
==========================================
  Files         181      218      +37     
  Lines       16633    18458    +1825     
==========================================
+ Hits        11257    14171    +2914     
+ Misses       5376     4287    -1089
Flag Coverage Δ
integrationtests 67.51% <ø> (-0.17%) ⬇️
unittests 57.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/feast/infra/materialization/snowflake_engine.py 93.18% <0.00%> (-0.41%) ⬇️
...tion/contrib/spark/spark_materialization_engine.py 71.84% <0.00%> (-0.28%) ⬇️
...offline_stores/contrib/trino_repo_configuration.py 20.00% <0.00%> (ø)
...ib/trino_offline_store/test_config/manual_tests.py 33.33% <0.00%> (ø)
...thon/feast/infra/online_stores/contrib/postgres.py 32.07% <0.00%> (ø)
...ffline_stores/contrib/trino_offline_store/trino.py 8.78% <0.00%> (ø)
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
sdk/python/feast/infra/utils/hbase_utils.py 41.17% <0.00%> (ø)
.../online_stores/contrib/mysql_repo_configuration.py 100.00% <0.00%> (ø)
...line_stores/contrib/athena_offline_store/athena.py 38.50% <0.00%> (ø)
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achals
achals enabled auto-merge (squash) October 18, 2022 16:56
felixwang9817
felixwang9817 approved these changes Oct 18, 2022
View reviewed changes

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 54faf61 into feast-dev:master Oct 18, 2022
@achals
achals deleted the achal/bad-links branch October 18, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @codecov-commenter @feast-ci-bot @felixwang9817