Merged
Conversation
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Codecov ReportBase: 67.53% // Head: 76.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3273 +/- ##
==========================================
+ Coverage 67.53% 76.80% +9.27%
==========================================
Files 181 218 +37
Lines 16514 18436 +1922
==========================================
+ Hits 11152 14160 +3008
+ Misses 5362 4276 -1086
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Closed
jerive
approved these changes
Oct 6, 2022
Collaborator
|
/lgtm |
kevjumba
approved these changes
Oct 6, 2022
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, jerive, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kevjumba
pushed a commit
to kevjumba/feast
that referenced
this pull request
Oct 6, 2022
* ci: Fix Feast UI tests Signed-off-by: Danny Chiao <danny@tecton.ai> * add test to workflow Signed-off-by: Danny Chiao <danny@tecton.ai> * add test to workflow Signed-off-by: Danny Chiao <danny@tecton.ai> * fix test suite in workflow Signed-off-by: Danny Chiao <danny@tecton.ai> * fix README Signed-off-by: Danny Chiao <danny@tecton.ai> * fix build Signed-off-by: Danny Chiao <danny@tecton.ai> * fix test name Signed-off-by: Danny Chiao <danny@tecton.ai> * upgrade caniuse Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Danny Chiao <danny@tecton.ai>
franciscojavierarceo
pushed a commit
to franciscojavierarceo/feast
that referenced
this pull request
Oct 18, 2022
* ci: Fix Feast UI tests Signed-off-by: Danny Chiao <danny@tecton.ai> * add test to workflow Signed-off-by: Danny Chiao <danny@tecton.ai> * add test to workflow Signed-off-by: Danny Chiao <danny@tecton.ai> * fix test suite in workflow Signed-off-by: Danny Chiao <danny@tecton.ai> * fix README Signed-off-by: Danny Chiao <danny@tecton.ai> * fix build Signed-off-by: Danny Chiao <danny@tecton.ai> * fix test name Signed-off-by: Danny Chiao <danny@tecton.ai> * upgrade caniuse Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Danny Chiao <danny@tecton.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #