Skip to content

fix: Fix docker image for feature-server #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Oct 6, 2022
Merged

fix: Fix docker image for feature-server #3272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de3e077
Fix
kevjumba Oct 5, 2022
4af06c3
Fix
kevjumba Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

build-publish-docker-images:
runs-on: ubuntu-latest
needs: get-version
needs: [get-version, build_wheels]
Copy link
Copy Markdown
Collaborator

@adchia adchia Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be after the publish sdk step not build wheels

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right fixed

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

strategy:
matrix:
component: [feature-server, feature-server-python-aws, feature-server-java, feature-transformation-server]
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ RUN apt update && \

RUN pip install pip --upgrade
COPY . .
Copy link
Copy Markdown
Collaborator

@adchia adchia Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

RUN pip install ".[aws,gcp,snowflake,redis,go,mysql,postgres]"
RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]"


RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ RUN apt update && \

RUN pip install pip --upgrade
COPY . .
RUN pip install ".[aws,gcp,snowflake,redis,go,mysql,postgres]"

RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]"

RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
Expand Down