Skip to content

feat: Add tag description in Field in the Feast UI #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Sep 28, 2022
Merged

feat: Add tag description in Field in the Feast UI #3258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: Add tag description in Field in the Feast UI 
Signed-off-by: Benjamin Tan <benjamin.tan@tech.jago.com>
  • Loading branch information
@benjamintanweihao
benjamintanweihao committed Sep 28, 2022
commit c6726c3faea6e1d84af16066f62a05f863205901
21 changes: 19 additions & 2 deletions ui/src/pages/features/FeatureOverviewTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@ import {
EuiHorizontalRule,
EuiLoadingSpinner,
EuiTitle,
EuiSpacer,
EuiPanel,
EuiFlexItem,
EuiText,
EuiDescriptionList,
EuiDescriptionListTitle,
EuiDescriptionListDescription,
} from "@elastic/eui";
import EuiCustomLink from "../../components/EuiCustomLink";
import TagsDisplay from "../../components/TagsDisplay";
import React from "react";
import { useParams } from "react-router-dom";
import useLoadFeature from "./useLoadFeature";
Expand Down Expand Up @@ -53,14 +56,28 @@ const FeatureOverviewTab = () => {

<EuiDescriptionListTitle>FeatureView</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<EuiCustomLink
<EuiCustomLink
href={`/p/${projectName}/feature-view/${FeatureViewName}`}
to={`/p/${projectName}/feature-view/${FeatureViewName}`}>
{FeatureViewName}
{FeatureViewName}
</EuiCustomLink>
</EuiDescriptionListDescription>
</EuiDescriptionList>
</EuiPanel>
<EuiSpacer size="m" />
<EuiPanel hasBorder={true} grow={false}>
<EuiTitle size="xs">
<h3>Tags</h3>
</EuiTitle>
<EuiHorizontalRule margin="xs" />
{featureData?.tags ? (
<TagsDisplay
tags={featureData.tags}
/>
) : (
<EuiText>No Tags specified on this field.</EuiText>
)}
</EuiPanel>
</EuiFlexItem>
</EuiFlexGroup>
</React.Fragment>
Expand Down