Skip to content

fix: Use configured user in env var instead of "user" for Trino #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Sep 29, 2022
Merged

fix: Use configured user in env var instead of "user" for Trino #3254

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc847fa
use env var user
ammarar Sep 27, 2022
76a2a1a
lint fix
ammarar Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use env var user 
Signed-off-by: ammarar <ammar.alrashed@gmail.com>
  • Loading branch information
@ammarar
ammarar committed Sep 27, 2022
commit bc847fac68de36a7a6d996962b9a6b57060b4ccc
9 changes: 4 additions & 5 deletions sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def pull_latest_from_table_or_query(
created_timestamp_column: Optional[str],
start_date: datetime,
end_date: datetime,
user: str = "user",
user: Optional[str] = None,
auth: Optional[Authentication] = None,
http_scheme: Optional[str] = None,
) -> TrinoRetrievalJob:
Expand All @@ -176,7 +176,6 @@ def pull_latest_from_table_or_query(
timestamps.append(created_timestamp_column)
timestamp_desc_string = " DESC, ".join(timestamps) + " DESC"
field_string = ", ".join(join_key_columns + feature_name_columns + timestamps)

client = _get_trino_client(
config=config, user=user, auth=auth, http_scheme=http_scheme
)
Expand Down Expand Up @@ -212,7 +211,7 @@ def get_historical_features(
registry: Registry,
project: str,
full_feature_names: bool = False,
user: str = "user",
user: Optional[str] = None,
auth: Optional[Authentication] = None,
http_scheme: Optional[str] = None,
) -> TrinoRetrievalJob:
Expand Down Expand Up @@ -303,7 +302,7 @@ def pull_all_from_table_or_query(
timestamp_field: str,
start_date: datetime,
end_date: datetime,
user: str = "user",
user: Optional[str] = None,
auth: Optional[Authentication] = None,
http_scheme: Optional[str] = None,
) -> RetrievalJob:
Expand Down Expand Up @@ -375,7 +374,7 @@ def _upload_entity_df_and_get_entity_schema(


def _get_trino_client(
config: RepoConfig, user: str, auth: Optional[Any], http_scheme: Optional[str]
config: RepoConfig, user: Optional[str], auth: Optional[Any], http_scheme: Optional[str]
) -> Trino:
client = Trino(
user=user,
Expand Down