Skip to content

fix: Build dockerfile correctly #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Sep 22, 2022
Merged

fix: Build dockerfile correctly #3239

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c425ccd
Build dockerfile correctly
felixwang9817 Sep 21, 2022
295b973
Update
felixwang9817 Sep 21, 2022
4311081
Fix
felixwang9817 Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ RUN apt update && \

RUN pip install pip --upgrade
COPY . .
RUN pip install ".feast[aws,gcp,snowflake,redis,go,mysql]"
Copy link
Copy Markdown
Member

@achals achals Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the period as well as feast?

Copy link
Copy Markdown
Collaborator Author

@felixwang9817 felixwang9817 Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch


RUN pip install -r requirements.txt
RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ RUN apt update && \

RUN pip install pip --upgrade
COPY . .
RUN pip install ".feast[aws,gcp,snowflake,redis,go,mysql]"

RUN pip install -r requirements.txt
RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
Expand Down
1 change: 0 additions & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/requirements.txt
View file
Open in desktop

This file was deleted.