Skip to content

fix: Dask zero division error if parquet dataset has only one partition #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Oct 12, 2022
Merged

fix: Dask zero division error if parquet dataset has only one partition #3236

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91835d1
fix: dask zero division error if parquet dataset has only one partition
mzwiessele Sep 23, 2022
69b3fae
Update file.py
mzwiessele Oct 6, 2022
f60862b
Update file.py
mzwiessele Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update file.py 
Signed-off-by: Max Zwiessle <ibinbei@gmail.com>
  • Loading branch information
@mzwiessele
mzwiessele committed Oct 12, 2022
commit 69b3fae7389cdb953a7b27abc559193bebaf18db
8 changes: 7 additions & 1 deletion sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,13 @@ def create_data_source(
prefix=f"{self.project_name}_{destination_name}"
)
table = pa.Table.from_pandas(df)
pq.write_to_dataset(table, dataset_path.name, compression="snappy")
pq.write_to_dataset(
table,
base_dir=dataset_path.name,
compression="snappy",
format="parquet",
existing_data_behavior="overwrite_or_ignore",
)
self.files.append(dataset_path)
return FileSource(
file_format=ParquetFormat(),
Expand Down