Skip to content

chore: Add example of getting historical features with entity SQL#3224

Merged
adchia merged 7 commits into
feast-dev:masterfrom
adchia:addEntitySQLToQuickstart
Sep 15, 2022
Merged

chore: Add example of getting historical features with entity SQL#3224
adchia merged 7 commits into
feast-dev:masterfrom
adchia:addEntitySQLToQuickstart

Conversation

@adchia

@adchia adchia commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Danny Chiao danny@tecton.ai

What this PR does / why we need it:
Tested this on the 3 quickstart templates I modified. Also added documentation changes to make this more clear

Which issue(s) this PR fixes:

Fixes #

@adchia
chore: Add example of getting historical features with entity SQL
12516f7 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
chore: Add example of getting historical features with entity SQL
62d18fd 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter

codecov-commenter commented Sep 15, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.87%. Comparing base (7bc1dff) to head (a27b6ba).
⚠️ Report is 1608 commits behind head on master.

Files with missing lines Patch % Lines
sdk/python/feast/errors.py 66.66% 2 Missing ⚠️
sdk/python/feast/infra/offline_stores/bigquery.py 50.00% 2 Missing ⚠️
sdk/python/feast/infra/offline_stores/snowflake.py 66.66% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3224      +/-   ##
==========================================
+ Coverage   67.03%   76.87%   +9.83%     
==========================================
  Files         175      213      +38     
  Lines       15948    18076    +2128     
==========================================
+ Hits        10691    13896    +3205     
+ Misses       5257     4180    -1077
Flag Coverage Δ
integrationtests 67.31% <61.53%> (+0.28%) ⬆️
unittests 58.26% <38.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adchia
Call this out in running feast in production guide
f0bd706 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
Call this out in running feast in production guide
c4f7019 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
Call this out in running feast in production guide
c7696d7 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
lint
065a727 
Signed-off-by: Danny Chiao <danny@tecton.ai>
achals
achals approved these changes Sep 15, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia
lint
a27b6ba 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot

feast-ci-bot commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Sep 15, 2022
@adchia adchia added the lgtm label Sep 15, 2022
@adchia adchia merged commit 59b4853 into feast-dev:master Sep 15, 2022
adchia added a commit that referenced this pull request Sep 15, 2022
@adchia
chore: Add example of getting historical features with entity SQL (#3224
a8d9a97 
)

* chore: Add example of getting historical features with entity SQL

Signed-off-by: Danny Chiao <danny@tecton.ai>

* chore: Add example of getting historical features with entity SQL

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Call this out in running feast in production guide

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Call this out in running feast in production guide

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Call this out in running feast in production guide

Signed-off-by: Danny Chiao <danny@tecton.ai>

* lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

* lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Danny Chiao <danny@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

@kevjumba kevjumba Awaiting requested review from kevjumba

@sfc-gh-madkins sfc-gh-madkins Awaiting requested review from sfc-gh-madkins

Assignees

@achals achals

@sfc-gh-madkins sfc-gh-madkins

Labels

approved lgtm ok-to-test size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adchia @codecov-commenter @feast-ci-bot @achals @sfc-gh-madkins