Skip to content

Pin Python SDK to minor versions for dependencies - #322

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
woop:lock-python-sdk-versions
Nov 28, 2019
Merged

Pin Python SDK to minor versions for dependencies#322
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
woop:lock-python-sdk-versions

Conversation

@woop

@woop woop commented Nov 24, 2019

Copy link
Copy Markdown
Member

No description provided.

@feast-ci-bot

feast-ci-bot commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thirteen37

thirteen37 commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

Is this absolutely necessary? Cos it's very opinioniated for a library to pin deps so strictly.

@woop

woop commented Nov 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Is this absolutely necessary? Cos it's very opinioniated for a library to pin deps so strictly.

For some of the more mature libraries like Pandas and Numpy, probably not.

For the Google libraries, I would prefer to pin them down for now and relax them later. We're constantly running into compatibility problems with different versions of the GCP SDKs, which is what in fact spurred this.

@thirteen37

thirteen37 commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

Sounds like that may lead to downstream problems for users who use other GCP libraries. Let's see.

@woop

woop commented Nov 25, 2019

Copy link
Copy Markdown
Member Author

Sounds like that may lead to downstream problems for users who use other GCP libraries. Let's see.

My assumption is that installation will happen within these constraints into a virtual environment.

Anyway, I will relax some of these.

@zhilingc

zhilingc commented Nov 27, 2019

Copy link
Copy Markdown
Collaborator

/lgtm

@woop

woop commented Nov 27, 2019

Copy link
Copy Markdown
Member Author

/retest

3 similar comments
@woop

woop commented Nov 27, 2019

Copy link
Copy Markdown
Member Author

/retest

@woop

woop commented Nov 28, 2019

Copy link
Copy Markdown
Member Author

/retest

@woop

woop commented Nov 28, 2019

Copy link
Copy Markdown
Member Author

/retest

@feast-ci-bot
feast-ci-bot merged commit 1074f5b into feast-dev:master Nov 28, 2019
@woop
woop deleted the lock-python-sdk-versions branch April 10, 2020 14:45
woop pushed a commit that referenced this pull request Oct 29, 2021
@felixwang9817 @gitbook-bot
GitBook: [#322] Redis
3e42fb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@pradithya pradithya Awaiting requested review from pradithya
@thirteen37 thirteen37 Awaiting requested review from thirteen37
@tims tims Awaiting requested review from tims
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@zhilingc zhilingc

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@woop @feast-ci-bot @thirteen37 @zhilingc