Skip to content

fix: Remove opening file object when validating S3 parquet source #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Sep 16, 2022
Merged

fix: Remove opening file object when validating S3 parquet source #3217

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1a315
Remove opening the file object
mzwiessele Sep 15, 2022
3827806
fix: linting error
mzwiessele Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove opening the file object 
Let pyarrow handle opening the path using the filesystem.

Signed-off-by: Max Z <max.zwiessele@babylonhealth.com>
  • Loading branch information
@mzwiessele
mzwiessele committed Sep 15, 2022
commit ea1a315c73eaad535cfcbb691466adef23d4eca8
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/file_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def get_table_column_names_and_types(
schema = ParquetDataset(path).schema.to_arrow_schema()
else:
schema = ParquetDataset(
filesystem.open_input_file(path), filesystem=filesystem
path, filesystem=filesystem
).schema

return zip(schema.names, map(str, schema.types))
Expand Down