Skip to content

fix: Return 422 on bad push source name #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 6 commits into from
Sep 29, 2022
Merged

fix: Return 422 on bad push source name #3214

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a0a7316
return 422 on bad push source name
Sep 15, 2022
c084b1b
fix: cant send empty df
Sep 15, 2022
570f674
return 422 on bad push source name
Sep 15, 2022
a4ff8c1
fix: cant send empty df
Sep 15, 2022
2397095
fix: json.dumps the body in the post :facepalm:
Sep 28, 2022
5ef4216
chore: merge conflicts
Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: cant send empty df 
Signed-off-by: Rob Howley <rhowley@seatgeek.com>
  • Loading branch information
@adchia
Rob Howley authored and adchia committed Sep 15, 2022
commit a4ff8c1afa1c97cbd06f08e8e875cb2225573f6f
10 changes: 9 additions & 1 deletion sdk/python/tests/integration/e2e/test_python_feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,19 @@ def test_push(python_fs_client):
@pytest.mark.integration
@pytest.mark.universal_online_stores
def test_push_source_does_not_exist(python_fs_client):
initial_temp = _get_temperatures_from_feature_server(
python_fs_client, location_ids=[1]
)[0]
response = python_fs_client.post(
"/push",
data={
"push_source_name": "push_source_does_not_exist",
"df": {},
"df": {
"location_id": [1],
"temperature": [initial_temp * 100],
"event_timestamp": [str(datetime.utcnow())],
"created": [str(datetime.utcnow())],
},
},
)
assert response.status_code == 422
Expand Down