Skip to content

feat: Filter subset features in postgres #3174 #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Sep 22, 2022
Merged

feat: Filter subset features in postgres #3174 #3203

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e140f9
Filter subset features
Sep 10, 2022
bc4b939
Fix python lint
NhuanTDBK Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix python lint 
Signed-off-by: NHUAN.TRAN <NhuanTDBK@users.noreply.github.com>
  • Loading branch information
@NhuanTDBK
NhuanTDBK committed Sep 13, 2022
commit bc4b939312e3b657c8ae0acefa1b3198f56740ed
8 changes: 6 additions & 2 deletions sdk/python/feast/infra/online_stores/contrib/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ def online_read(
SELECT entity_key, feature_name, value, event_ts
FROM {} WHERE entity_key = ANY(%s);
"""
).format(sql.Identifier(_table_id(project, table)),),
).format(
sql.Identifier(_table_id(project, table)),
),
(keys,),
)
else:
Expand All @@ -131,7 +133,9 @@ def online_read(
SELECT entity_key, feature_name, value, event_ts
FROM {} WHERE entity_key = ANY(%s) and feature_name = ANY(%s);
"""
).format(sql.Identifier(_table_id(project, table)),),
).format(
sql.Identifier(_table_id(project, table)),
),
(keys, requested_features),
)

Expand Down