Skip to content

feat: Add mysql as online store #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 17 commits into from
Sep 22, 2022
Merged

feat: Add mysql as online store #3190

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3ad3773
update remove debug
hao-affirm Sep 7, 2022
7d98a4a
add interface
hao-affirm Sep 7, 2022
cc13d24
fix lint
hao-affirm Sep 7, 2022
0527d5d
fix lint
hao-affirm Sep 8, 2022
312af8b
update sql
hao-affirm Sep 8, 2022
7bd0662
update ci reqs
hao-affirm Sep 8, 2022
9a547bb
remove pip index
hao-affirm Sep 8, 2022
5d84e06
format
hao-affirm Sep 9, 2022
edceadf
fix unit test issue
hao-affirm Sep 9, 2022
28090e5
fix lint issue
hao-affirm Sep 9, 2022
7f2afd6
add entity_key_serialization_version
hao-affirm Sep 9, 2022
84b5246
update doc
hao-affirm Sep 9, 2022
d17ffe6
format
hao-affirm Sep 9, 2022
a1aed88
format
hao-affirm Sep 9, 2022
5717d8c
fix makefile typo
hao-affirm Sep 9, 2022
9f64788
move to func
hao-affirm Sep 10, 2022
0d7d831
format
hao-affirm Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format 
Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
  • Loading branch information
@hao-affirm
hao-affirm committed Sep 10, 2022
commit 0d7d8319cbba6001e804cb2f77ef2bb0db09e06b
8 changes: 3 additions & 5 deletions sdk/python/feast/infra/online_stores/contrib/mysql_online_store/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import pytz
from pydantic import StrictStr
from pymysql.connections import Connection
from pymysql.cursors import Cursor

from feast import Entity, FeatureView, RepoConfig
from feast.infra.key_encoding_utils import serialize_entity_key
Expand All @@ -31,7 +32,6 @@ class MySQLOnlineStoreConfig(FeastConfigBaseModel):
port: Optional[int] = None



class MySQLOnlineStore(OnlineStore):
"""
An online store implementation that uses MySQL.
Expand Down Expand Up @@ -208,11 +208,9 @@ def teardown(
_drop_table_and_index(cur, project, table)


def _drop_table_and_index(cur, project: str, table: FeatureView) -> None:
def _drop_table_and_index(cur: Cursor, project: str, table: FeatureView) -> None:
table_name = _table_id(project, table)
cur.execute(
f"DROP INDEX {table_name}_ek ON {table_name};"
)
cur.execute(f"DROP INDEX {table_name}_ek ON {table_name};")
cur.execute(f"DROP TABLE IF EXISTS {table_name}")


Expand Down