Skip to content

ci: Fix java feature server Dockerfile to use updated builder - #3152

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/jdk-fix
Aug 29, 2022
Merged

ci: Fix java feature server Dockerfile to use updated builder#3152
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/jdk-fix

Conversation

@achals

@achals achals commented Aug 29, 2022

Copy link
Copy Markdown
Member

maven:3.6-jdk-11 has been yanked from dockerhub: https://hub.docker.com/_/maven

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals
ci: Fix java feature server Dockerfile to use updated builder
36ee4ad 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter

codecov-commenter commented Aug 29, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 67.11% // Head: 58.27% // Decreases project coverage by -8.84% ⚠️

Coverage data is based on head (36ee4ad) compared to base (8fbf13c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3152      +/-   ##
==========================================
- Coverage   67.11%   58.27%   -8.85%     
==========================================
  Files         175      209      +34     
  Lines       15905    17586    +1681     
==========================================
- Hits        10675    10248     -427     
- Misses       5230     7338    +2108
Flag Coverage Δ
integrationtests ?
unittests 58.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 159 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

felixwang9817
felixwang9817 approved these changes Aug 29, 2022
View reviewed changes

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Aug 29, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit a14234d into feast-dev:master Aug 29, 2022
@achals
achals deleted the achal/jdk-fix branch August 30, 2022 18:05
adchia pushed a commit that referenced this pull request Aug 31, 2022
@achals @adchia
ci: Fix java feature server Dockerfile to use updated builder (#3152)
9f7a69e 
Signed-off-by: Achal Shah <achals@gmail.com>

Signed-off-by: Achal Shah <achals@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @codecov-commenter @feast-ci-bot @felixwang9817