Skip to content

fix: Make infer dummy entity join key idempotent #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Aug 22, 2022
Merged

fix: Make infer dummy entity join key idempotent #3115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Infer dummy entity join key once 
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
  • Loading branch information
@sfc-gh-madkins
sfc-gh-madkins committed Aug 20, 2022
commit ac2d34a83aa589bb0f36e51badf95d920ed421f7
6 changes: 5 additions & 1 deletion sdk/python/feast/inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,11 @@ def update_feature_views_with_inferred_features_and_entities(
)

# Infer a dummy entity column for entityless feature views.
if len(fv.entities) == 1 and fv.entities[0] == DUMMY_ENTITY_NAME:
if (
len(fv.entities) == 1
and fv.entities[0] == DUMMY_ENTITY_NAME
and not fv.entity_columns
):
fv.entity_columns.append(Field(name=DUMMY_ENTITY_ID, dtype=String))

# Run inference for entity columns if there are fewer entity fields than expected.
Expand Down