Skip to content

fix: Teardown tables for Snowflake Materialization testing #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Aug 19, 2022
Merged

fix: Teardown tables for Snowflake Materialization testing #3106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Teardown tables for Snowflake Materialization testing 
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
  • Loading branch information
@sfc-gh-madkins
sfc-gh-madkins committed Aug 19, 2022
commit 340818130bb489dbe90418f40ddc8bb0da829cb0
2 changes: 2 additions & 0 deletions sdk/python/tests/integration/materialization/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def test_snowflake_materialization_consistency_internal():
validate_offline_online_store_consistency(fs, driver_stats_fv, split_dt)
finally:
fs.teardown()
snowflake_environment.data_source_creator.teardown()


@pytest.mark.integration
Expand Down Expand Up @@ -123,3 +124,4 @@ def test_snowflake_materialization_consistency_external():
validate_offline_online_store_consistency(fs, driver_stats_fv, split_dt)
finally:
fs.teardown()
snowflake_environment.data_source_creator.teardown()