Skip to content

fix: Update sql.py #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 4 commits into from
Aug 17, 2022
Merged

fix: Update sql.py #3096

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f602f6c
Update sql.py
hao-affirm Aug 16, 2022
513e16a
add test
hao-affirm Aug 17, 2022
9cf3f05
add test
hao-affirm Aug 17, 2022
d3ae960
fix lint
hao-affirm Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update sql.py 
Fix a bug that `name = name or obj.name if hasattr(obj, "name") else None` has wrong order sequence.

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
  • Loading branch information
@hao-affirm
hao-affirm committed Aug 17, 2022
commit f602f6c55e28c73a26b20b9509e14a2c7ce84c47
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ def _apply_object(
):
self._maybe_init_project_metadata(project)

name = name or obj.name if hasattr(obj, "name") else None
name = name or (obj.name if hasattr(obj, "name") else None)
assert name, f"name needs to be provided for {obj}"

with self.engine.connect() as conn:
Expand Down