Skip to content

fix: Fix feature service inference logic #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Aug 19, 2022
Merged

fix: Fix feature service inference logic #3089

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1e09ad3
Add __init__.py files to allow test files to share names
felixwang9817 Aug 16, 2022
5a5c6f6
Add feature service tests
felixwang9817 Aug 12, 2022
07eaba6
Fix feature service inference logic
felixwang9817 Aug 16, 2022
51174b3
Remove stray `__init__.py` file
felixwang9817 Aug 16, 2022
45ec63c
Fix comments
felixwang9817 Aug 17, 2022
7a43b8f
Add check
felixwang9817 Aug 17, 2022
40d7965
Temp
felixwang9817 Aug 17, 2022
8dfb6db
Address comments
felixwang9817 Aug 17, 2022
c4d9c5a
Fix
felixwang9817 Aug 18, 2022
64dfdef
Address comments
felixwang9817 Aug 18, 2022
31115ac
Fix
felixwang9817 Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comments 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Aug 17, 2022
commit 8dfb6dba0c8b2cf35debf75e2dd1efe158126ba0
46 changes: 19 additions & 27 deletions sdk/python/feast/feature_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,35 +100,29 @@ def infer_features(self, fvs_to_update: Dict[str, FeatureView]):
"""
for feature_grouping in self._features:
if isinstance(feature_grouping, BaseFeatureView):
projection = feature_grouping.projection


if feature_grouping.name not in fvs_to_update:
raise FeatureViewMissingDuringFeatureServiceInference(
feature_view_name=feature_grouping.name,
feature_service_name=self.name,
)

projection = feature_grouping.projection
if projection.desired_features:
# The projection wants to select a specific set of inferred features.
# Example: FeatureService(features=[fv[["inferred_feature"]]]), where
# 'fv' is a feature view that was defined without a schema.
if feature_grouping.name in fvs_to_update:
# Validate that the selected features have actually been inferred.
desired_features = set(projection.desired_features)
actual_features = set(
[
f.name
for f in fvs_to_update[feature_grouping.name].features
]
)
assert desired_features.issubset(actual_features)

# Extract the selected features and add them to the projection.
projection.features = []
for f in fvs_to_update[feature_grouping.name].features:
if f.name in desired_features:
projection.features.append(f)
else:
raise FeatureViewMissingDuringFeatureServiceInference(
feature_view_name=feature_grouping.name,
feature_service_name=self.name,
)
# First we validate that the selected features have actually been inferred.
desired_features = set(projection.desired_features)
actual_features = set(
[f.name for f in fvs_to_update[feature_grouping.name].features]
)
assert desired_features.issubset(actual_features)

# Then we extract the selected features and add them to the projection.
projection.features = []
for f in fvs_to_update[feature_grouping.name].features:
if f.name in desired_features:
projection.features.append(f)

continue

Expand All @@ -142,9 +136,7 @@ def infer_features(self, fvs_to_update: Dict[str, FeatureView]):
# The projection wants to select all possible inferred features.
# Example: FeatureService(features=[fv]), where 'fv' is a feature view that
# was defined without a schema.
projection.features = fvs_to_update[
feature_grouping.name
].features
projection.features = fvs_to_update[feature_grouping.name].features
else:
raise ValueError(
f"The feature service {self.name} has been provided with an invalid type "
Expand Down