Fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
feast-dev · feast-ci-bot · Aug 19, 2022 · Aug 5, 2022 · Aug 10, 2022 · Aug 10, 2022
commit 2b2ff409d93f70d15a290d0c5bace138345e9419
diff --git a/Makefile b/Makefile
@@ -147,6 +147,7 @@ test-python-universal-mssql:
 	FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.offline_stores.contrib.mssql_repo_configuration \
 	PYTEST_PLUGINS=feast.infra.offline_stores.contrib.mssql_offline_store.tests \
  	FEAST_USAGE=False IS_TEST=True \
+	FEAST_LOCAL_ONLINE_CONTAINER=True \
  	python -m pytest -n 8 --integration \
  	 	-k "not gcs_registry and \
 			not s3_registry and \

diff --git a/README.md b/README.md
@@ -152,7 +152,7 @@ The list below contains the functionality that contributors are planning to deve
   * [x] [Redshift source](https://docs.feast.dev/reference/data-sources/redshift)
   * [x] [BigQuery source](https://docs.feast.dev/reference/data-sources/bigquery)
   * [x] [Parquet file source](https://docs.feast.dev/reference/data-sources/file)
-  * [x] [Synapse source (contrib plugin)](https://docs.feast.dev/reference/data-sources/mssql)
+  * [x] [Azure Synapse + Azure SQL source (contrib plugin)](https://docs.feast.dev/reference/data-sources/mssql)
   * [x] [Hive (community plugin)](https://github.com/baineng/feast-hive)
   * [x] [Postgres (contrib plugin)](https://docs.feast.dev/reference/data-sources/postgres)
   * [x] [Spark (contrib plugin)](https://docs.feast.dev/reference/data-sources/spark)
@@ -161,7 +161,7 @@ The list below contains the functionality that contributors are planning to deve
   * [x] [Snowflake](https://docs.feast.dev/reference/offline-stores/snowflake)
   * [x] [Redshift](https://docs.feast.dev/reference/offline-stores/redshift)
   * [x] [BigQuery](https://docs.feast.dev/reference/offline-stores/bigquery)
-  * [x] [Synapse (contrib plugin)](https://docs.feast.dev/reference/offline-stores/mssql.md)
+  * [x] [Azure Synapse + Azure SQL (contrib plugin)](https://docs.feast.dev/reference/offline-stores/mssql.md)
   * [x] [Hive (community plugin)](https://github.com/baineng/feast-hive)
   * [x] [Postgres (contrib plugin)](https://docs.feast.dev/reference/offline-stores/postgres)
   * [x] [Trino (contrib plugin)](https://github.com/Shopify/feast-trino)

@@ -71,7 +71,7 @@
   * [Spark (contrib)](reference/data-sources/spark.md)
   * [PostgreSQL (contrib)](reference/data-sources/postgres.md)
   * [Trino (contrib)](reference/data-sources/trino.md)
-  * [Synapse/MsSql (contrib)](reference/data-sources/mssql.md)
+  * [Azure Synapse + Azure SQL (contrib)](reference/data-sources/mssql.md)
 * [Offline stores](reference/offline-stores/README.md)
   * [Overview](reference/offline-stores/overview.md)
   * [File](reference/offline-stores/file.md)
@@ -81,7 +81,7 @@
   * [Spark (contrib)](reference/offline-stores/spark.md)
   * [PostgreSQL (contrib)](reference/offline-stores/postgres.md)
   * [Trino (contrib)](reference/offline-stores/trino.md)
-  * [Synapse/MsSql (contrib)](reference/offline-stores/mssql.md)
+  * [Azure Synapse + Azure SQL (contrib)](reference/offline-stores/mssql.md)
 * [Online stores](reference/online-stores/README.md)
   * [SQLite](reference/online-stores/sqlite.md)
   * [Snowflake](reference/online-stores/snowflake.md)

@@ -10,7 +10,7 @@ The list below contains the functionality that contributors are planning to deve
   * [x] [Redshift source](https://docs.feast.dev/reference/data-sources/redshift)
   * [x] [BigQuery source](https://docs.feast.dev/reference/data-sources/bigquery)
   * [x] [Parquet file source](https://docs.feast.dev/reference/data-sources/file)
-  * [x] [Synapse source (contrib plugin)](https://docs.feast.dev/reference/data-sources/mssql)
+  * [x] [Azure Synapse + Azure SQL source (contrib plugin)](https://docs.feast.dev/reference/data-sources/mssql)
   * [x] [Hive (community plugin)](https://github.com/baineng/feast-hive)
   * [x] [Postgres (contrib plugin)](https://docs.feast.dev/reference/data-sources/postgres)
   * [x] [Spark (contrib plugin)](https://docs.feast.dev/reference/data-sources/spark)
@@ -19,7 +19,7 @@ The list below contains the functionality that contributors are planning to deve
   * [x] [Snowflake](https://docs.feast.dev/reference/offline-stores/snowflake)
   * [x] [Redshift](https://docs.feast.dev/reference/offline-stores/redshift)
   * [x] [BigQuery](https://docs.feast.dev/reference/offline-stores/bigquery)
-  * [x] [Synapse (contrib plugin)](https://docs.feast.dev/reference/offline-stores/mssql.md)
+  * [x] [Azure Synapse + Azure SQL (contrib plugin)](https://docs.feast.dev/reference/offline-stores/mssql.md)
   * [x] [Hive (community plugin)](https://github.com/baineng/feast-hive)
   * [x] [Postgres (contrib plugin)](https://docs.feast.dev/reference/offline-stores/postgres)
   * [x] [Trino (contrib plugin)](https://github.com/Shopify/feast-trino)

@@ -297,7 +297,6 @@ def from_proto(data_source: DataSourceProto) -> Any:
             raise ValueError("Could not identify the source type being added.")
 
         if data_source_type == DataSourceProto.SourceType.CUSTOM_SOURCE:
-            data_source.data_source_class_type = "feast.infra.offline_stores.contrib.mssql_offline_store.mssqlserver_source.MsSqlServerSource"
             cls = get_data_source_class_from_type(data_source.data_source_class_type)
             return cls.from_proto(data_source)
 

@@ -77,7 +77,7 @@ def pull_latest_from_table_or_query(
         end_date: datetime,
     ) -> RetrievalJob:
         warnings.warn(
-            "The synapse/mssql offline store is an experimental feature in alpha development. "
+            "The Azure Synapse + Azure SQL offline store is an experimental feature in alpha development. "
             "Some functionality may still be unstable so functionality can change in the future.",
             RuntimeWarning,
         )
@@ -128,7 +128,7 @@ def pull_all_from_table_or_query(
     ) -> RetrievalJob:
         assert type(data_source).__name__ == "MsSqlServerSource"
         warnings.warn(
-            "The synapse/mssql offline store is an experimental feature in alpha development. "
+            "The Azure Synapse + Azure SQL offline store is an experimental feature in alpha development. "
             "Some functionality may still be unstable so functionality can change in the future.",
             RuntimeWarning,
         )
@@ -166,7 +166,7 @@ def get_historical_features(
         full_feature_names: bool = False,
     ) -> RetrievalJob:
         warnings.warn(
-            "The synapse/mssql offline store is an experimental feature in alpha development. "
+            "The Azure Synapse + Azure SQL offline store is an experimental feature in alpha development. "
             "Some functionality may still be unstable so functionality can change in the future.",
             RuntimeWarning,
         )

@@ -16,7 +16,7 @@
 from feast.repo_config import RepoConfig
 from feast.value_type import ValueType
 
-# Make sure spark warning doesn't raise more than once.
+# Make sure azure warning doesn't raise more than once.
 warnings.simplefilter("once", RuntimeWarning)
 
 
@@ -115,7 +115,7 @@ def __init__(
         owner: Optional[str] = None,
     ):
         warnings.warn(
-            "The synapse/mssql data source is an experimental feature in alpha development. "
+            "The Azure Synapse + Azure SQL data source is an experimental feature in alpha development. "
             "Some functionality may still be unstable so functionality can change in the future.",
             RuntimeWarning,
         )