Skip to content

ci: In nightly CI, cleanup dynamo tables related to integration tests#3055

Merged
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
adchia:dynamoCleanupWorkflow
Aug 15, 2022
Merged

ci: In nightly CI, cleanup dynamo tables related to integration tests#3055
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
adchia:dynamoCleanupWorkflow

Conversation

@adchia

@adchia adchia commented Aug 10, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This is to patch fix the random leaking DynamoDB tables in CI.

Which issue(s) this PR fixes:

Fixes #

Comment thread infra/scripts/cleanup_dynamo_ci.py Outdated
adchia added 3 commits August 15, 2022 10:27
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia force-pushed the dynamoCleanupWorkflow branch from 3396e41 to 4d858d6 Compare August 15, 2022 14:35
@codecov-commenter

codecov-commenter commented Aug 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3055 (4d858d6) into master (66d2c76) will increase coverage by 8.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
+ Coverage   67.44%   75.93%   +8.48%     
==========================================
  Files         169      203      +34     
  Lines       14936    16839    +1903     
==========================================
+ Hits        10074    12786    +2712     
+ Misses       4862     4053     -809     
Flag Coverage Δ
integrationtests 67.29% <ø> (-0.15%) ⬇️
unittests 58.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
sdk/python/feast/infra/utils/hbase_utils.py 41.17% <0.00%> (ø)
...thon/feast/infra/utils/postgres/postgres_config.py 100.00% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...k/python/feast/infra/materialization/lambda/app.py 26.66% <0.00%> (ø)
...offline_stores/contrib/trino_repo_configuration.py 20.00% <0.00%> (ø)
...stores/contrib/trino_offline_store/trino_source.py 5.37% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...s/contrib/trino_offline_store/tests/data_source.py 17.64% <0.00%> (ø)
... and 98 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 41851be into feast-dev:master Aug 15, 2022
@adchia adchia deleted the dynamoCleanupWorkflow branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants