Skip to content

fix: Parse inline data sources #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Aug 15, 2022
Merged

fix: Parse inline data sources #3036

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
047437b
Remove deprecated CLI warnings
felixwang9817 Aug 5, 2022
b0dc405
Fix repo parsing logic
felixwang9817 Aug 8, 2022
e733c89
Add tests
felixwang9817 Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove deprecated CLI warnings 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Aug 12, 2022
commit 047437b8320ff8695543090453b1e6b8de7559dc
12 changes: 0 additions & 12 deletions sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# limitations under the License.
import json
import logging
import warnings
from datetime import datetime
from pathlib import Path
from typing import List, Optional
Expand Down Expand Up @@ -45,7 +44,6 @@
from feast.utils import maybe_local_tz

_logger = logging.getLogger(__name__)
warnings.filterwarnings("ignore", category=DeprecationWarning, module="(?!feast)")


class NoOptionDefaultFormat(click.Command):
Expand Down Expand Up @@ -197,11 +195,6 @@ def data_source_describe(ctx: click.Context, name: str):
print(e)
exit(1)

warnings.warn(
"Describing data sources will only work properly if all data sources have names or table names specified. "
"Starting Feast 0.24, data source unique names will be required to encourage data source discovery.",
RuntimeWarning,
)
print(
yaml.dump(
yaml.safe_load(str(data_source)), default_flow_style=False, sort_keys=False
Expand All @@ -224,11 +217,6 @@ def data_source_list(ctx: click.Context):

from tabulate import tabulate

warnings.warn(
"Listing data sources will only work properly if all data sources have names or table names specified. "
"Starting Feast 0.24, data source unique names will be required to encourage data source discovery",
RuntimeWarning,
)
print(tabulate(table, headers=["NAME", "CLASS"], tablefmt="plain"))


Expand Down