Skip to content

chore: Add types hints and set created_timestamp in sql registry #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Aug 8, 2022
Merged

chore: Add types hints and set created_timestamp in sql registry #3033

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab437d
chore: Add types for some methods in the sql registry
achals Aug 8, 2022
7f8d7bb
created_timestamp
achals Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: Add types for some methods in the sql registry 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Aug 8, 2022
commit 6ab437d0fc4cf97c817f94e6eed8984e98b1bebf
9 changes: 5 additions & 4 deletions sdk/python/feast/infra/registry_stores/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,15 +688,16 @@ def _apply_object(
self,
table: Table,
project: str,
id_field_name,
obj,
proto_field_name,
name=None,
id_field_name: str,
obj: Any,
proto_field_name: str,
name: Optional[str] = None,
):
self._maybe_init_project_metadata(project)

name = name or obj.name if hasattr(obj, "name") else None
assert name, f"name needs to be provided for {obj}"

with self.engine.connect() as conn:
update_datetime = datetime.utcnow()
update_time = int(update_datetime.timestamp())
Expand Down