chore!: Deprecate request data source#3024
Merged
feast-ci-bot merged 1 commit intoAug 6, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3024 +/- ##
==========================================
- Coverage 77.70% 77.69% -0.01%
==========================================
Files 194 194
Lines 16099 16094 -5
==========================================
- Hits 12509 12504 -5
Misses 3590 3590
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
cb14306 to
1bb156b
Compare
adchia
approved these changes
Aug 5, 2022
adchia
left a comment
Collaborator
There was a problem hiding this comment.
surprised this doesn't break anything
/lgtm
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
BREAKING CHANGE: Deprecate
RequestDataSource.