Skip to content

chore: Fix integration test commands for contrib plugins + local integration tests. - #3017

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
adchia:updateContribTests
Aug 5, 2022
Merged

chore: Fix integration test commands for contrib plugins + local integration tests.#3017
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
adchia:updateContribTests

Conversation

@adchia

@adchia adchia commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Formerly, the integration test commands were slightly broken:

  • The local integration tests would pull in GCP dependencies
  • The Spark + Trino integration tests were coupled together and did not exclude all the right tests
  • The CONTRIBUTING.md did not hint at how to run contrib tests

Which issue(s) this PR fixes:

Fixes #

…ntegration tests to not depend on GCP

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit c02120d into feast-dev:master Aug 5, 2022
@adchia
adchia deleted the updateContribTests branch August 5, 2022 18:02
adchia added a commit that referenced this pull request Aug 5, 2022
…gration tests. (#3017)

* chore: Fix integration test commands for contrib plugins. Fix local integration tests to not depend on GCP

Signed-off-by: Danny Chiao <danny@tecton.ai>

* title

Signed-off-by: Danny Chiao <danny@tecton.ai>
adchia added a commit that referenced this pull request Aug 10, 2022
…gration tests. (#3017)

* chore: Fix integration test commands for contrib plugins. Fix local integration tests to not depend on GCP

Signed-off-by: Danny Chiao <danny@tecton.ai>

* title

Signed-off-by: Danny Chiao <danny@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants